Fix typescript constructor parameter properties#262
Conversation
plugin-transform-classes drop typescript constructor parameter propetries syntax.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
soh335
changed the title
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 85.21% 85.21%
=======================================
Files 141 141
Lines 4533 4533
Branches 706 706
=======================================
Hits 3863 3863
Misses 598 598
Partials 72 72
Continue to review full report at Codecov.
|
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
rafeca
left a comment
rafeca
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR! It looks great 😍
Can you do the small improvement to the test? After that it's ready to land 😃
|
@rafeca I don't have plan to commit. But it seems not to be tested about constructor parameter properties. I can't find test codes of after transpiling typescripts. Is it ok ? |
|
Yes, this is fine, thanks a lot for the PR! I'm going to land it 😄 |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
rafeca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@rafeca any progress ? |
Summary: <!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. --> **Summary** <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> issue react#258. metro-react-native-babel-preset don't recognize typescript constructor parameter properties, currently. **Test plan** <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. --> not yet. Pull Request resolved: react#262 Reviewed By: mjesun Differential Revision: D10009176 Pulled By: rafeca fbshipit-source-id: 62f6279658464df127033aa322c76f77c9694aed
4 participants
Summary
issue #258.
metro-react-native-babel-preset don't recognize typescript constructor parameter properties, currently.
Test plan
not yet.